[Openmp-commits] [PATCH] D78566: [OpenMP] Add scaffolding for negative runtime tests

Joel E. Denny via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Apr 21 08:04:17 PDT 2020


jdenny created this revision.
jdenny added reviewers: ABataev, AndreyChurbanov, jdoerfert, hfinkel, Hahnfeld, grokos, AlexEichenberger.
Herald added subscribers: guansong, yaxunl, mgorny.
Herald added a project: OpenMP.
jdenny added a child revision: D78170: [OpenMP] target_data_begin: fail on device alloc fail.

Without this patch, the openmp project's test suites do not appear to
have support for negative tests.  However, D78170 <https://reviews.llvm.org/D78170> needs to add a test
that an expected runtime failure occurs.

This patch makes `not` visible in all of the openmp project's test
suites.  In all but `libomptarget/test`, it should be possible for a
test author to insert `not` before a use of the lit substitution for 
running a test program.  In `libomptarget/test`, that substitution is
target-specific, and its value is `echo` when the target is not 
available.  In that case, inserting `not` before a lit substitution
would expect an `echo` fail, so this patch instead defines a separate
lit substitution for expected runtime fails.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78566

Files:
  openmp/README.rst
  openmp/cmake/OpenMPTesting.cmake
  openmp/libomptarget/deviceRTLs/nvptx/test/lit.site.cfg.in
  openmp/libomptarget/test/lit.cfg
  openmp/libomptarget/test/lit.site.cfg.in
  openmp/runtime/test/lit.site.cfg.in
  openmp/tools/archer/tests/lit.site.cfg.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78566.258996.patch
Type: text/x-patch
Size: 5309 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20200421/2664a1de/attachment.bin>


More information about the Openmp-commits mailing list