[Openmp-commits] [PATCH] D78170: [OpenMP] target_data_begin: fail on device alloc fail

Joel E. Denny via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Apr 14 17:25:44 PDT 2020


jdenny created this revision.
jdenny added reviewers: ABataev, AndreyChurbanov, jdoerfert, hfinkel.
Herald added subscribers: guansong, yaxunl, mgorny.
Herald added a project: OpenMP.

Without this patch, target_data_begin continues after an illegal
mapping or an out-of-memory error on the device.  With this patch, it
terminates the runtime with an error instead.

The new test exercises only illegal mappings.  I didn't think of a
good way to exercise out-of-memory errors from the test suite.

Most of this patch is concerned with adding support for negative tests
in the openmp project's test suites.  Hopefully I didn't miss an
existing mechanism.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78170

Files:
  openmp/README.rst
  openmp/cmake/OpenMPTesting.cmake
  openmp/libomptarget/src/omptarget.cpp
  openmp/libomptarget/test/lit.cfg
  openmp/libomptarget/test/lit.site.cfg.in
  openmp/libomptarget/test/mapping/alloc_fail.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78170.257559.patch
Type: text/x-patch
Size: 5133 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20200415/b79b97bb/attachment.bin>


More information about the Openmp-commits mailing list