[Openmp-commits] [PATCH] D67447: Enable tasks dependencies hashmaps resizing

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Sep 13 21:46:47 PDT 2019


jdoerfert added reviewers: ABataev, Hahnfeld, protze.joachim, grokos.
jdoerfert added a comment.

I like this. If there are objections, questions, concerns, please raise them now.



================
Comment at: runtime/src/kmp_taskdeps.cpp:72
+  if (gen >= MAX_GEN)
+    return current_dephash;
+  size_t new_size = sizes[gen];
----------------
Do we want to give up here? I've seen people with *a lot* of dynamic tasks so we might want to scale somehow.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67447/new/

https://reviews.llvm.org/D67447





More information about the Openmp-commits mailing list