[Openmp-commits] [PATCH] D69220: [OpenMP] Enable OpenBSD support

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Oct 29 10:45:24 PDT 2019


Hahnfeld added a comment.

In D69220#1725680 <https://reviews.llvm.org/D69220#1725680>, @AndreyChurbanov wrote:

> I've meant this difference better to be applied during the commit if possible:
>
>   ./clang/tools/clang-format/git-clang-format --diff openmp/runtime/src/z_Linux_util.cpp
>   diff --git a/openmp/runtime/src/z_Linux_util.cpp b/openmp/runtime/src/z_Linux_util.cpp
>   index fa4a65a..9f79a61 100644
>   --- a/openmp/runtime/src/z_Linux_util.cpp
>   +++ b/openmp/runtime/src/z_Linux_util.cpp
>   @@ -2151,10 +2151,9 @@ int __kmp_is_address_mapped(void *addr) {
>        if (kiv.kve_end == end)
>          break;
>  
>   -    if (kiv.kve_start >= (uint64_t)addr &&
>   -        kiv.kve_end <= (uint64_t)addr) {
>   -          found = 1;
>   -          break;
>   +    if (kiv.kve_start >= (uint64_t)addr && kiv.kve_end <= (uint64_t)addr) {
>   +      found = 1;
>   +      break;
>        }
>        kiv.kve_start += 1;
>      }
>


Ah, good catch: I only looked at the closing braces which were indeed fixed compared to the original patch. @devnexen please do during commit as Andrey suggested.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69220/new/

https://reviews.llvm.org/D69220





More information about the Openmp-commits mailing list