[Openmp-commits] [PATCH] D69424: [NFC][libomptarget] move remaining device specific code out of omptarget-nvptx.h

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield marked 2 inline comments as done.
JonChesterfield added a comment.

"Target specific" is suffering a little as an abstraction.

We have hardware specific (e.g. barrier implementation), language specific (e.g. attributes), driver specific (the above struct), vendor extensions (extra stuff one adds to the top level interface.h).



================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:16
+#include <cuda.h>
 #include <stdint.h>
 
----------------
ABataev wrote:
> Do we need `stdint.h` include here?
Sure. There's uint32_t and similar in this header, which could reasonably be the first or only one included in a translation unit.


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h:34-37
+/// Device environment data
+struct omptarget_device_environmentTy {
+  int32_t debug_level;
+};
----------------
ABataev wrote:
> Is this really target specific thing?
This one is a driver/plugin specific thing. The hsa struct has another couple of fields.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69424/new/

https://reviews.llvm.org/D69424