[Openmp-commits] [PATCH] D68369: Use -1 to indicate all lanes, to handle 32 and 64 wide architectures

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield marked an inline comment as done.
JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/parallel.cu:323
     IncParallelLevel(IsActiveParallelRegion,
-                     IsActiveParallelRegion ? 0xFFFFFFFF : 1u);
+                     IsActiveParallelRegion ? __kmpc_impl_all_lanes : 1u);
   }
----------------
ronlieb wrote:
> is there some applicable naming convention for named constants?
Probably, but I'm not sure what. These files are a mixture of the LLVM convention and another one. At some point I guess we should batch convert all the symbols we control to the LLVM convention.

I think a strict reading of the guidelines would be `__KmpcImplAllLanes`, which I struggle to read. Or possibly `__KMPCImplAllLanes`. Overall I quite like `-1`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68369/new/

https://reviews.llvm.org/D68369