[Openmp-commits] [PATCH] D70414: [libomptarget] Implement a CMakeLists.txt for amdgcn

[Jon Chesterfield via Phabricator via Openmp-commits]

JonChesterfield marked 2 inline comments as done.
JonChesterfield added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt:56
+  DIRECTORY)
+
+file(GLOB cuda_sources ${CMAKE_CURRENT_SOURCE_DIR}/src/*.cu
----------------
Glob has the advantage that this file will keep working as other source is added to amdgcn or common.

This will break as soon as common contains a file that amdgcn doesn't want to compile. At that point, this can become a whitelist instead.

I'm happy to list out the sources explicitly if that's strongly preferred.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt:73
+
+if(mcpus)
+else()
----------------
Builds a specialised version of the library for various amdgcn architectures


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70414/new/

https://reviews.llvm.org/D70414