[Openmp-commits] [PATCH] D70328: [libomptarget][nfc] Move some source into common from nvptx

Mon Nov 18 09:20:41 PST 2019

ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.

In D70328#1750166 <https://reviews.llvm.org/D70328#1750166>, @JonChesterfield wrote:

> In D70328#1750148 <https://reviews.llvm.org/D70328#1750148>, @ABataev wrote:
>
> > The patch does not break the build.
>
>
> Which patch do you refer to?
>
> Neither the `task.cu #include common/task.cpp` nor moving task.cu without renaming break the build for me, but it's worth noting which configuration you've checked.

I was just saying that the patch is good and it does not(!) break the build. SO, if everybody else is fine with it, you can land it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70328/new/

https://reviews.llvm.org/D70328