[Openmp-commits] [PATCH] D70328: [libomptarget][nfc] Move some source into common from nvptx

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added a comment.

In D70328#1748187 <https://reviews.llvm.org/D70328#1748187>, @JonChesterfield wrote:

> In D70328#1748116 <https://reviews.llvm.org/D70328#1748116>, @ABataev wrote:
>
> > It breaks the build:
> >
> >   ...omptarget-nvptx_generated_data_sharing.cu.o:1:8: warning: null character(s) ignored [enabled by default]
> >    ...
> >   
>
>
> That's interesting. I see the same failure on one machine but not on a second so thought it was a quirk of the local setup. Please could you try the new revision? It leaves data_sharing.cu totally unchanged (the first revision ran that file through a remove-non-ascii perl fragment intended to patch up whatever character nvcc didn't like).


Nope, still the same. I think the reason is `-x cu` option in nvcc invocation command, obj file is treated as cuda source file with this option


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70328/new/

https://reviews.llvm.org/D70328