[Openmp-commits] [PATCH] D70328: [libomptarget][nfc] Move some source into common from nvptx

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Nov 15 11:08:18 PST 2019


JonChesterfield created this revision.
JonChesterfield added reviewers: jdoerfert, ABataev, grokos.
Herald added subscribers: openmp-commits, mgorny.
Herald added a project: OpenMP.

[libomptarget][nfc] Move some source into common from nvptx

Moves some source that compiles cleanly under amdgcn into a common subdirectory
Includes some non-trivial files and some headers. Drops the cuda file extension,
though the files won't yet compile without some of the cuda builtins.

The build systems for different architectures seem unlikely to have much in
common. The idea is therefore to set include paths such that files under
common/src compile as if they were under arch/src as the mechanism for sharing.
In particular, files under common/src need to be able to include target_impl.h.

The corresponding -Icommon is left out in favour of explicit includes on the
basis that the it makes it clearer which files under common are used by a given
architecture.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70328

Files:
  openmp/libomptarget/deviceRTLs/common/debug.h
  openmp/libomptarget/deviceRTLs/common/src/cancel.cpp
  openmp/libomptarget/deviceRTLs/common/src/critical.cpp
  openmp/libomptarget/deviceRTLs/common/src/loop.cpp
  openmp/libomptarget/deviceRTLs/common/src/task.cpp
  openmp/libomptarget/deviceRTLs/common/state-queue.h
  openmp/libomptarget/deviceRTLs/common/state-queuei.h
  openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt
  openmp/libomptarget/deviceRTLs/nvptx/src/cancel.cu
  openmp/libomptarget/deviceRTLs/nvptx/src/critical.cu
  openmp/libomptarget/deviceRTLs/nvptx/src/data_sharing.cu
  openmp/libomptarget/deviceRTLs/nvptx/src/debug.h
  openmp/libomptarget/deviceRTLs/nvptx/src/loop.cu
  openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h
  openmp/libomptarget/deviceRTLs/nvptx/src/state-queue.h
  openmp/libomptarget/deviceRTLs/nvptx/src/state-queuei.h
  openmp/libomptarget/deviceRTLs/nvptx/src/support.cu
  openmp/libomptarget/deviceRTLs/nvptx/src/task.cu

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70328.229599.patch
Type: text/x-patch
Size: 8033 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20191115/11985bda/attachment-0001.bin>


More information about the Openmp-commits mailing list