[Openmp-commits] [PATCH] D70186: [libomptarget][nfc] Use cuda variable wrappers from support.h

Jon Chesterfield via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Nov 13 08:46:19 PST 2019


JonChesterfield added a comment.

Thanks. In general I agree re: NFC. At present I'm being cautious after the non-reproducible build errors of last week.

The missing symbols were root caused - `__forceinline__` is not equal to always_inline - but duplicate symbols have me at a  loss, especially when the supporti.h => support.cu patch didn't show the issue. Hopefully Alexey will run into them again on one of the subdivided patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70186/new/

https://reviews.llvm.org/D70186





More information about the Openmp-commits mailing list