[Openmp-commits] [PATCH] D69927: [libomptarget] Export __kmp_internal_end_fini to fix [Thin]LTO build

Andrey Churbanov via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Nov 7 07:04:49 PST 2019


AndreyChurbanov added a comment.

Looks acceptable to me.  As well as removing the __kmp_internal_end_fini symbol at all, as it duplicates the functionality of __kmp_internal_end_dtor which has attribute "destructor".  I am OK with either solution, would be good to hear others opinion.

Does anybody knows a platform where "__attribute__((destructor))" does not work?  If yes then we may need both destructors in place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69927/new/

https://reviews.llvm.org/D69927





More information about the Openmp-commits mailing list