[Openmp-commits] [PATCH] D69857: [libomptarget] Replace INLINE with DEVICE to work around nvcc deleting forceinline symbols

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added a comment.

In D69857#1734819 <https://reviews.llvm.org/D69857#1734819>, @JonChesterfield wrote:

> I think we should apply this patch anyway. It fixes the nvcc build which we have multiple reports of breakage from.
>
> I can't see a reason why clang would conjure duplicate symbols, and have failed to reproduce anything like that, so am hopeful that it's a quirk of your current build setup.
>
> Fundamentally I believe that nvcc would fail to handle inline functions correctly, as it fails to do a bunch of things correctly, and I believe that clang will build this correctly from a clean directory.
>
> Otherwise, please provide enough details of your build setup that I can reproduce the failure.


Bad decision. I would suggest to revert your pr3vious patches and restore intial code layout and then try step by step fixing it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69857/new/

https://reviews.llvm.org/D69857