[Openmp-commits] [PATCH] D69718: [libomptarget] Implement target_impl for amdgcn

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h:23
+#define DEVICE __device__
+#define INLINE __inline__ DEVICE
+#define NOINLINE __noinline__ DEVICE
----------------
`__forceinline__`?


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h:81-82
+INLINE void __kmpc_impl_unpack(uint64_t val, uint32_t &lo, uint32_t &hi) {
+  lo = (uint32_t)(val & 0x00000000FFFFFFFFL);
+  hi = (uint32_t)((val & 0xFFFFFFFF00000000L) >> 32);
+}
----------------
Maybe ULL suffix instead of just L?


================
Comment at: openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h:90
+static const __kmpc_impl_lanemask_t __kmpc_impl_all_lanes =
+    UINT64_C(0xffffffffffffffff);
+
----------------
0xffffffffffffffffULL?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69718/new/

https://reviews.llvm.org/D69718