[Openmp-commits] [PATCH] D56274: [OPENMP][NVPTX]Fix incompatibility of __syncthreads with LLVM, NFC.

Wed May 29 12:12:22 PDT 2019

arsenm added a comment.

In D56274#1521772 <https://reviews.llvm.org/D56274#1521772>, @arsenm wrote:

> In D56274#1521762 <https://reviews.llvm.org/D56274#1521762>, @grokos wrote:
>
> > In D56274#1520909 <https://reviews.llvm.org/D56274#1520909>, @arsenm wrote:
> >
> > > D62581 <https://reviews.llvm.org/D62581>
> >
> >
> > Thanks for this! Should we now revert this patch to use `syncthreads()` once again instead of the asm instruction?
>
>
> Yes

The asm also isn't necessarily a real workaround. Inline asm call sites need to be marked as convergent as well

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56274/new/

https://reviews.llvm.org/D56274