[Openmp-commits] [PATCH] D60884: [OpenMP][libomptarget] Enable usage of unified memory for declare target link variables

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

Looks mostly good, one last question about the return type of `__tgt_rtl_init_requires` that I noticed only now.



================
Comment at: libomptarget/plugins/cuda/src/rtl.cpp:276
+  DeviceInfo.RequiresFlags = RequiresFlags;
+  return RequiresFlags;
+}
----------------
This will truncate `int64_t RequiresFlags` to `int32_t`. Does it make sense to change the return type to `int64_t`?


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60884/new/

https://reviews.llvm.org/D60884