[Openmp-commits] [PATCH] D59735: Fix gettid warnings on FreeBSD

[Dimitry Andric via Phabricator via Openmp-commits]

dim created this revision.
dim added reviewers: emaste, jlpeyton, krytarowski, mgorny, protze.joachim.
Herald added subscribers: jdoerfert, jfb.
Herald added a project: OpenMP.

[Split off from D59451 <https://reviews.llvm.org/D59451> to get this fix in separately]

While building the 8.0 releases on FreeBSD, I encountered the following
warnings in openmp quite a few times:

  In file included from projects/openmp/runtime/src/kmp_settings.cpp:27:
  projects/openmp/runtime/src/kmp_wrapper_getpid.h:35:2: warning: #warning is a language extension [-Wpedantic]
  #warning No gettid found, use getpid instead
   ^
  projects/openmp/runtime/src/kmp_wrapper_getpid.h:35:2: warning: No gettid found, use getpid instead [-W#warnings]
  2 warnings generated.

I added a gettid wrapper that uses FreeBSD's pthread_getthreadid_np(3)
function for this.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D59735

Files:
  runtime/src/kmp_wrapper_getpid.h


Index: runtime/src/kmp_wrapper_getpid.h
===================================================================
--- runtime/src/kmp_wrapper_getpid.h
+++ runtime/src/kmp_wrapper_getpid.h
@@ -23,6 +23,9 @@
 #if KMP_OS_DARWIN
 // OS X
 #define __kmp_gettid() syscall(SYS_thread_selfid)
+#elif KMP_OS_FREEBSD
+#include <pthread_np.h>
+#define __kmp_gettid() pthread_getthreadid_np()
 #elif KMP_OS_NETBSD
 #include <lwp.h>
 #define __kmp_gettid() _lwp_self()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59735.191995.patch
Type: text/x-patch
Size: 450 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20190323/ad060ee7/attachment.bin>