[Openmp-commits] [PATCH] D59451: Fix gettid warnings and one test on FreeBSD

Sat Mar 16 07:53:04 PDT 2019

krytarowski added a comment.

In D59451#1431917 <https://reviews.llvm.org/D59451#1431917>, @dim wrote:

> In D59451#1431899 <https://reviews.llvm.org/D59451#1431899>, @krytarowski wrote:
>
> > If we want to depend on pthread, please go for canonical `-pthread`.
>
>
> Hm, I copied this from several other tests, which use the same construct, so I don't see why this one should be different.  (In fact pthread detection is a can of worms, many configure scripts go through extreme lengths to determine the exact magical incantation needed... but most of the time `-lpthread` works everywhere, except on Windows of course. :) )

NetBSD requires `-pthread` as it defines `-D_REENTRANT` that enables reentran APIs. If it works with `-lpthread`, it's by an accident.

Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59451/new/

https://reviews.llvm.org/D59451