[Openmp-commits] [PATCH] D62393: [OPENMP][NVPTX]Mark parallel level counter as volatile.

Alexey Bataev via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jun 13 14:32:23 PDT 2019


ABataev added a comment.

In D62393#1542533 <https://reviews.llvm.org/D62393#1542533>, @jdoerfert wrote:

> In D62393#1542505 <https://reviews.llvm.org/D62393#1542505>, @ABataev wrote:
>
> > In D62393#1542465 <https://reviews.llvm.org/D62393#1542465>, @hfinkel wrote:
> >
> > > It makes me suspicious of that too. But no one here believes that anyone was trying to subvert the system and produce an inferior result - it is very likely that everyone had, and continues to have, the best of intentions.
> >
> >
> > Maybe, just maybe, before starting treat someone's activity "suspicious" better to start to try to understand something? To read something, to ask the questions in the proper manner, etc.?
>
>
> I did ask questions [0,1] and read *a lot* [2,3].
>
> Here, and in D62199 <https://reviews.llvm.org/D62199>, my comments resulted in:
>
> - Complex technical discussions with commitments towards improving the patches and review process ([4] to name one), and
> - Various comments and accusations that people found inappropriate ([1,5-11] to restrict it to these patches only). The one you refer to is in [1] and in my follow up [12] I agreed that my words were not well chosen.
>
>   [0] https://reviews.llvm.org/D62199#1512617 [1] https://reviews.llvm.org/D62393#1528421 [2] https://reviews.llvm.org/D62199#1515182 [3] https://reviews.llvm.org/D62199#1517073
>
>   [4] https://reviews.llvm.org/D62199#1515072
>
>   [5] https://reviews.llvm.org/D62199#1512638 [6] https://reviews.llvm.org/D62199#1513126 [7] https://reviews.llvm.org/D62199#1514027 [8] https://reviews.llvm.org/D62393#1533461 [9] https://reviews.llvm.org/D62393#1539086 [10] https://reviews.llvm.org/D62393#1539630 [11] https://reviews.llvm.org/D62393#1542505
>
>   [12] https://reviews.llvm.org/D62199#1515182


[0] was enough for me to treat all your next actions in a certain sense. Your questions do not mean anything, you already made the decision and all the questions were just to confirm this first judgement.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62393/new/

https://reviews.llvm.org/D62393





More information about the Openmp-commits mailing list