[Openmp-commits] [PATCH] D62841: [openmp] Use libffi only when LLVM_ENABLE_FFI is on
Jonas Hahnfeld via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Tue Jun 4 23:20:19 PDT 2019
Hahnfeld added a comment.
Oh, `LLVM_ENABLE_FFI` is off by default? That's not good, because we rely on the plugins to test libomptarget. So changing the default will have a negative impact on test coverage. I'm afraid that's not a good idea, even if we are now using libffi when `LLVM_ENABLE_FFI = Off`. We could still add `LIBOMPTARGET_ENABLE_FFI` (at the top-level CMakeLists.txt, please) and default to on, but I'm not sure if that's of much help.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the Openmp-commits