[Openmp-commits] [PATCH] D60972: [OpenMP 5.0] libomptarget interface for declare mapper functions

George Rokos via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Jul 29 14:42:15 PDT 2019


grokos added a comment.

In D60972#1605210 <https://reviews.llvm.org/D60972#1605210>, @lildmh wrote:

> In D60972#1605188 <https://reviews.llvm.org/D60972#1605188>, @grokos wrote:
>
> > Now that the clang-side patch is finalized, this is almost good to go. What is missing from this patch is a test. Can you add something under `libomptarget/test/offloading/`?
>
>
> Sure, since this is very simple I'll add a simple test. Do you think the test should be in libomptarget/test/offloading/ or libomptarget/test/api/?


Sorry, I meant `libomptarget/test/mapping/`!

The `api` directory is meant for test cases calling `omp_*` API functions, which is not the case here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60972/new/

https://reviews.llvm.org/D60972





More information about the Openmp-commits mailing list