[Openmp-commits] [PATCH] D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps

Tue Jul 23 07:00:46 PDT 2019

Hahnfeld added a comment.

In D65001#1597305 <https://reviews.llvm.org/D65001#1597305>, @gtbercea wrote:

> @Hahnfeld can you list the tests you would like to see please? And then I'll add them.

All new functionality should be tested unless there is a good reason it cannot:

In D65001#1594465 <https://reviews.llvm.org/D65001#1594465>, @Hahnfeld wrote:

> Please add tests at least
>
> - for the API, ie that `omp_target_alloc` returns distinct memory (I suggest to `omp_target_memcpy` from host to allocated memory to a different host memory and change the first host memory before copying back).
> - that memory regions are indeed shared (in a `target data` region, the host should see updates from the host without an update and vice versa)

Additionally, I requested tests for `omp_target_is_present` inline.

Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65001/new/

https://reviews.llvm.org/D65001