[Openmp-commits] [PATCH] D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps
Jonas Hahnfeld via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Fri Jul 19 13:28:59 PDT 2019
Hahnfeld added inline comments.
Comment at: libomptarget/include/omptargetplugin.h:73
// success, return zero. Otherwise, return an error code.
-int32_t __tgt_rtl_data_delete(int32_t ID, void *TargetPtr);
+int32_t __tgt_rtl_data_delete(int32_t ID, void *TargetPtr, bool ForceDelete);
I'm not fond of changing the API and I'm not sure why we need to: If the program uses unified memory, the generic part of libomptarget should not call the plugin (except for firstprivates, as I understand the code). Am I missing something that wouldn't make this work?
CHANGES SINCE LAST ACTION
More information about the Openmp-commits