[Openmp-commits] [PATCH] D45890: [OMPT] Add implementation and tests of Archer tool

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: tools/archer/ompt-tsan.cpp:175-192
+void ARCHER_WEAK
+annotatehappensafter_(const char *file, int *line,
+                           const volatile void *cv) {
+  AnnotateHappensAfter(file, *line, cv);
+}
+void ARCHER_WEAK
+annotatehappensbefore_(const char *file, int *line,
----------------
Moving the code doesn't solve the underlying issues:
1. It's not required for Archer, or at least for the basic tests to pass.
2. It's not related to OpenMP per se.

Besides, with the current usage to dynamically load the library during runtime, it will not resolve symbols during linkage.


================
Comment at: tools/archer/ompt-tsan.cpp:383-384
+
+  /// Whether this task is currently executing a barrier.
+  bool Included;
+
----------------
This comment doesn't sound right.


================
Comment at: tools/archer/ompt-tsan.cpp:923-924
+
+  if (archer_flags->print_ompt_counters)
+    all_counter = new callback_counter_t[MAX_THREADS];
+
----------------
This functionality is not used in the tests and could be a separate patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45890/new/

https://reviews.llvm.org/D45890