[Openmp-commits] [PATCH] D64808: [OPENMMP] Resolve lost LoopTripCnt for subsequent loops in same thread.
George Rokos via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Wed Jul 17 06:52:50 PDT 2019
grokos accepted this revision.
grokos added a comment.
This revision is now accepted and ready to land.
In D64808#1589239 <https://reviews.llvm.org/D64808#1589239>, @ronlieb wrote:
> @grokos any comments here please?
> hoping to get this patch in before the 9.0 branch.
The patch should definitely be committed as it fixes a potential problem with multiple threads. Regarding the test, I'm a bit torn. I don't like the idea of relying on debug messages either, but you are right that the plugin may change the number of teams so we cannot predict consistently what `omp_get_num_teams()` will return on each architecture. I will accept the patch as-is so that the bugfix in merged into the 9.0 release but we will need to revise the test in the future.
CHANGES SINCE LAST ACTION
More information about the Openmp-commits