[Openmp-commits] [PATCH] D64808: [OPENMMP] Resolve lost LoopTripCnt for subsequent loops in same thread.
Ron Lieberman via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Tue Jul 16 10:53:14 PDT 2019
ronlieb marked an inline comment as done.
ronlieb added inline comments.
Comment at: libomptarget/test/offloading/looptripcnt.c:38
+ printf("num_threads %d num_teams %d\n", num_threads, num_teams);
+// DEBUG: loop trip count is 128
+ return 0;
> I think, instead of the debug messages better to check the results of the `printf`s.
I initially thought about that, but I am worried that depending on what architecture you run on it might produce different numbers of teams, if the thread limit was a lot smaller than on a gpu for example.
but what I am really trying to test is that we found the loopTripCount to pass into the runtime.
if you strongly prefer that I still do so, I will be happy to change the test. I would of course still keep the DP message for diagnostic purposes down the road.
CHANGES SINCE LAST ACTION
More information about the Openmp-commits