[Openmp-commits] [PATCH] D64808: [OPENMMP] Resolve lost LoopTripCnt for subsequent loops in same thread.

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: libomptarget/src/omptarget.cpp:738
+    Device.LoopTripCnt.erase(I);
+    DP("loop trip count is %ld.\n", ltc);
+  }
----------------
Use `%lu` instead, it is an unsigned type.


================
Comment at: libomptarget/test/offloading/looptripcnt.c:38
+  printf("num_threads %d num_teams %d\n", num_threads[0], num_teams[0]);
+// DEBUG: loop trip count is 128
+  return 0;
----------------
I think, instead of the debug messages better to check the results of the `printf`s.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64808/new/

https://reviews.llvm.org/D64808