[Openmp-commits] [PATCH] D64080: [OPENMP]Make __kmpc_push_tripcount thread safe.
Hal Finkel via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Wed Jul 3 14:34:13 PDT 2019
hfinkel added a comment.
In D64080#1569283 <https://reviews.llvm.org/D64080#1569283>, @jdoerfert wrote:
> In D64080#1569266 <https://reviews.llvm.org/D64080#1569266>, @hfinkel wrote:
> > In D64080#1568348 <https://reviews.llvm.org/D64080#1568348>, @ABataev wrote:
> > > Added note.
> > The patch description says that you add a trip count "per thread", but the code is adding a trip count per device. Could this still cause a problem if multiple threads have target regions for the same device?
> It's one map per device, each map contains one trip count per OpenMP thread.
Ah, indeed. Nevermind.
CHANGES SINCE LAST ACTION
More information about the Openmp-commits