[Openmp-commits] [PATCH] D55725: [OpenMP] Add libs to clang-dedicated directories

Joel E. Denny via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sat Jan 26 19:01:09 PST 2019


jdenny added a reviewer: jroelofs.
jdenny added a comment.

In D55725#1372778 <https://reviews.llvm.org/D55725#1372778>, @jdenny wrote:

> Assuming installation to that non-version-locked Clang-dedicated directory, one comment there is, "Now if you've built things against those libs, and upgrade your clang version, you are not tied to the new libc++ that comes with it, as you would be with libc++ placed in the resource dir."  At first, that sounded nonsensical to me: if every Clang upgrade clobbers the previous Clang's libc++ because the installation directory isn't version-locked, you're always tied to the new libc++.


Ah, I just realized that doesn't make sense because of the `.so` version numbers for libc++.  So, the idea there is that, if Clang looks in a directory specific to its own version, it won't find old `.so` versions of libraries.  Right?

> Or do they assume that the resource directory appears early in the library search path and their proposed non-version-locked Clang-dedicated directory does not?  If that's right, then their proposal doesn't elevate libraries within the search patch.

So, I still don't know if it's ok to elevate libc++ earlier in the search path.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55725/new/

https://reviews.llvm.org/D55725





More information about the Openmp-commits mailing list