[Openmp-commits] [PATCH] D56274: [OPENMP][NVPTX]Fix incompatibility of __syncthreads with LLVM, NFC.

Thu Jan 3 08:40:30 PST 2019

ABataev added a comment.

In D56274#1345233 <https://reviews.llvm.org/D56274#1345233>, @grokos wrote:

> I'll accept the patch for the sake of consistency and correctness of execution. Just one question:
>
> > which cost is too high
>
> So should we expect a performance penalty until function copy is fixed in LLVM and we can revert back to `__syncthreads()`?

No, the cost in LLVM terms is high, but in the end, we end up with absolutely the same code as before. That's why it is marked as NFC.

Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56274/new/

https://reviews.llvm.org/D56274