[Openmp-commits] [PATCH] D56804: Fix thread_limits to work properly for teams construct

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: runtime/src/kmp.h:1851
                 thread) */
+  int thread_limit; /* internal control for thread-limit-var */
   int max_active_levels; /* internal control for max_active_levels */
----------------
AndreyChurbanov wrote:
> protze.joachim wrote:
> > Is this entry necessary? From my understanding of the spec, one copy per cg or thread should be sufficient.
> Maybe you are correct, but the specification says it is per-task ICV.  So this looks a safer way to go. E.g. in future the setter routine can be added.
The spec does not litteraly say per-task ICV. The scope is "data environment". 

data environment: The variables associated with the execution of a given //region//.

Since the value can only be set/changed on a per-cg base, this should be sufficient.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56804/new/

https://reviews.llvm.org/D56804