[Openmp-commits] [PATCH] D71988: [OpenMP][WIP] Make the kmp_depend_info type fit in 128 bits.

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Dec 30 09:36:48 PST 2019


jdoerfert added a comment.

> I would expect that some versioning is needed..

Versioning is fine with me. Versioning the runtime would be even preferable.

> If this really brings a benefit, we need new entry functions and update the compiler(s).

We go to great lengths to align to cache lines in some structs, e.g., `kmp_depnode`, but we are literally wasting space and alignment for others. Even if we do not adopt this, we should start to adopt some best practices.

FWIW. This was never intended to be committed like this, thus no reviewers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71988/new/

https://reviews.llvm.org/D71988





More information about the Openmp-commits mailing list