[Openmp-commits] [PATCH] D66019: [libomptarget] Remove duplicate RTLRequiresFlags per device

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Aug 9 10:53:34 PDT 2019


Hahnfeld created this revision.
Hahnfeld added reviewers: gtbercea, grokos.
Herald added a project: OpenMP.
Herald added a subscriber: openmp-commits.

We have one global RTLs.RequiresFlags, I don't see a need to make a
copy per device that the runtime manages. This was problematic anyway
because the copy happened during the first __tgt_register_lib(). This
made it impossible to call __tgt_register_requires() from normal
functions for testing.
Hence, this change also fixes unified_shared_memory/shared_update.c for
older versions of Clang that don't call __tgt_register_requires() before
__tgt_register_lib().


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D66019

Files:
  openmp/libomptarget/src/api.cpp
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/src/device.h
  openmp/libomptarget/src/omptarget.cpp
  openmp/libomptarget/src/rtl.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66019.214405.patch
Type: text/x-patch
Size: 6826 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20190809/0a7498af/attachment-0001.bin>


More information about the Openmp-commits mailing list