[Openmp-commits] [PATCH] D65340: [OpenMP][libomptarget] Add support for close map modifier

[Gheorghe-Teodor Bercea via Phabricator via Openmp-commits]

gtbercea marked 4 inline comments as done.
gtbercea added inline comments.


================
Comment at: libomptarget/test/unified_shared_memory/close_manual.c:6
+
+// UNSUPPORTED: clang-3, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9
+
----------------
gtbercea wrote:
> Hahnfeld wrote:
> > This completely misses the point: This test is supposed to work with older versions of clang, even those that don't support `close`.
> This is because of __tgt_register_requires not because of the other two methods.
I believe clang-9 will work with unified shared memory. Because we are calling the tgt functions manually we can enable this test for clang-9 even if it tests the close functionality.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65340/new/

https://reviews.llvm.org/D65340