[Openmp-commits] [PATCH] D60223: [OpenMP][libomptarget] Add support for target link variables when unified memory is enabled

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: libomptarget/include/omptarget.h:51
+  /// Target link
+  OMP_TGT_MAPTYPE_USE_HOST_VAR    = 0x400,
   // member of struct, member given by [16 MSBs] - 1
----------------
Do you really need this flag? Can you use something different? For example, `OMP_TGT_MAPTYPE_LITERAL` or `OMP_TGT_MAPTYPE_PRIVATE`?


================
Comment at: libomptarget/plugins/cuda/src/rtl.cpp:443
+        // be overwritten.
+        cuMemcpyHtoD(cuptr, e->addr, 8);
+        DP("Copy linked variable host address (" DPxMOD ")"
----------------
`8`->`sizeof(void*)`


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60223/new/

https://reviews.llvm.org/D60223