[Openmp-commits] [PATCH] D54342: Add omp_get_device_num() and update several other device API functions

[Wilmarth, Terry L via Openmp-commits]

OK, on my internal build these are showing up as weak symbols with nm.  But on my LLVM build, not.  Will look into the LLVM build to make sure it allows for weak attribute.

-----Original Message-----
From: Gheorghe-Teodor Bercea via Phabricator [mailto:reviews at reviews.llvm.org] 
Sent: Thursday, November 29, 2018 4:23 PM
To: Wilmarth, Terry L <terry.l.wilmarth at intel.com>; Churbanov, Andrey <Andrey.Churbanov at intel.com>; Bae, Hansang <hansang.bae at intel.com>; Narayanaswamy, Ravi <ravi.narayanaswamy at intel.com>; Peyton, Jonathan L <jonathan.l.peyton at intel.com>
Cc: gheorghe-teod.bercea at ibm.com; a.bataev at hotmail.com; llvm-commits at lists.llvm.org; openmp-commits at lists.llvm.org; jatin.bhateja at gmail.com; lildmh at gmail.com; Gregory.Rodgers at amd.com; acjacob at us.ibm.com; zhang.guansong at gmail.com
Subject: [PATCH] D54342: Add omp_get_device_num() and update several other device API functions

gtbercea added a comment.

After this patch, omp_get_num_devices() seems to wrongly return 0 even when devices are present.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54342/new/

https://reviews.llvm.org/D54342