[Openmp-commits] [PATCH] D54342: Add omp_get_device_num() and update several other device API functions

Terry Wilmarth via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Nov 29 13:55:42 PST 2018


tlwilmar added a comment.

In D54342#1313417 <https://reviews.llvm.org/D54342#1313417>, @ABataev wrote:

> This commit conflicts with libomptarget. libomptarget have the same functions and the code may be confused during execution which version of the functions should be executed. This conflict should be resolved somehow. Before that, I think, this patch must be reverted.


Everything should be implemented as weak functions that libomptarget should override if it is present.  Did I miss one?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54342/new/

https://reviews.llvm.org/D54342





More information about the Openmp-commits mailing list