[Openmp-commits] [PATCH] D54969: [OpenMP][libomptarget] Add new version of SPMD deinit kernel function with argument

Alexey Bataev via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Nov 27 13:07:32 PST 2018


ABataev added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu:188
 
+EXTERN void __kmpc_spmd_kernel_deinit_v2(int16_t RequiresOMPRuntime) {
+  // We're not going to pop the task descr stack of each thread since
----------------
Could try to avoid copy-paste here? The original function may just call the new one with the `isRuntimeInitialized()` argument.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54969/new/

https://reviews.llvm.org/D54969





More information about the Openmp-commits mailing list