[Openmp-commits] [PATCH] D46530: [OMPT] Rename ompt_wait_id to omp_wait_id

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue May 8 00:27:01 PDT 2018


Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.

Sounds good if that's the direction of the spec. It was clear that the implementation of OMPT might change based on newer Technical Reports.



================
Comment at: runtime/src/include/50/ompt.h.var:290
 typedef void (*ompt_wait_callback_t) (
-    ompt_wait_id_t wait_id                /* wait data                           */
+    omp_wait_id_t wait_id                /* wait data                           */
 );
----------------
You should add another space before `/*` here and in many more places below


https://reviews.llvm.org/D46530





More information about the Openmp-commits mailing list