[Openmp-commits] [PATCH] D46210: [OpenMP] Use LIBOMPDEVICE_DEBUG env var to control debug messages on the device side

Guansong Zhang via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri May 4 10:07:25 PDT 2018


guansong marked 2 inline comments as done.
guansong added a comment.

In https://reviews.llvm.org/D46210#1085401, @grokos wrote:

> In https://reviews.llvm.org/D46210#1085391, @guansong wrote:
>
> > In https://reviews.llvm.org/D46210#1085335, @grokos wrote:
> >
> > > May I suggest that we use something like `LIBOMPTARGET_DEVICE_RTL_DEBUG` instead of `LIBOMPDEVICE_DEBUG`? I think this name is more descriptive of what the env var does.
> >
> >
> > It's kind of long, but I am ok also if you do not want to shorten it.
>
>
> I think it's more important to have a clear name than a short one. Let's change it.





https://reviews.llvm.org/D46210





More information about the Openmp-commits mailing list