[Openmp-commits] [PATCH] D47903: [OpenMP] Use C++11 Atomics - barrier, tasking, and lock code

Andrey Churbanov via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Jun 29 11:23:24 PDT 2018


AndreyChurbanov added inline comments.


================
Comment at: runtime/src/kmp_taskdeps.cpp:43
   __kmp_init_lock(&node->dn.lock);
   node->dn.nrefs = 1; // init creates the first reference to the node
 #ifdef KMP_SUPPORT_GRAPH_OUTPUT
----------------
This store can be relaxed I think.


================
Comment at: runtime/src/kmp_tasking.cpp:1984
+  KMP_ATOMIC_ST_RLX(&tg_new->count, 0);
   tg_new->cancel_request = cancel_noreq;
   tg_new->parent = taskdata->td_taskgroup;
----------------
This assignment also can be relaxed I think.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D47903





More information about the Openmp-commits mailing list