[Openmp-commits] [PATCH] D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added inline comments.


================
Comment at: runtime/src/kmp_tasking.cpp:3754
               next_task_bounds.get_upper_offset()));
-    __kmp_omp_task(gtid, next_task, true); // schedule new task
+    __kmpc_omp_task(NULL, gtid, next_task); // schedule new task
     lower = upper + st; // adjust lower bound for the next iteration
----------------
same as below


================
Comment at: runtime/src/kmp_tasking.cpp:3910
   p->num_t_min = num_t_min;
-  __kmp_omp_task(gtid, new_task, true); // schedule new task
+  __kmpc_omp_task(NULL, gtid, new_task); // schedule new task
 
----------------
We somehow need to pass a return-address in here. So probably a new variant of __kmpc_omp_task, which takes the address and adds it to the ompt-callback invocation?


================
Comment at: runtime/src/kmp_tasking.cpp:3955
   ompt_task_info_t *task_info = __ompt_get_task_info_object(0);
+  kmp_uint64 iteration_count = *lb < *ub ? *ub - *lb + 1 : *lb - *ub + 1;
   if (ompt_enabled.ompt_callback_work) {
----------------
Shouldn't there be st(ride) in the formula?


https://reviews.llvm.org/D47709