[Openmp-commits] [PATCH] D49857: [OpenMP] Implement GOMP doacross compatibility

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added a comment.

In https://reviews.llvm.org/D49857#1181735, @Hahnfeld wrote:

> In https://reviews.llvm.org/D49857#1180955, @jlpeyton wrote:
>
> > I can create a typical 2D wavefront testcase that uses the actual doacross clauses, and we can omit gcc from kmp_doacross_check.c.  Does this suffice?
>
>
> I think it's good to have an end-to-end test now that the library has interfaces for all compilers.
>
> For `kmp_doacross_check.c` another possibility would be to guard the call to `__kmpc_doacross_fini` in `#ifndef __GNUC__`. I'm not sure if this is elegant though...


Intel compiler defines __GNUC__ to express compatibility I guess, so it is safer to disable the whole test.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D49857