[Openmp-commits] [PATCH] D47709: [OMPT] Fix OMPT callbacks for the taskloop construct and add testcase

[Hansang Bae via Phabricator via Openmp-commits]

hbae added inline comments.


================
Comment at: runtime/src/kmp_tasking.cpp:1602
+//    resumed later.
+kmp_int32 __kmpc_omp_taskloop_task(ident_t *loc_ref, kmp_int32 gtid,
+                                   kmp_task_t *new_task, void *codeptr_ra) {
----------------
Can we change the function name to `__kmp_omp_taskloop_task`?
__kmpc_* is usually for ABI functions.


================
Comment at: runtime/src/kmp_tasking.cpp:4005
+#else
+  __kmpc_omp_task(NULL, gtid, new_task); // schedule new task
+#endif
----------------
I think it is better to keep the original code (`__kmp_omp_task()` call) at this line.


https://reviews.llvm.org/D47709