[Openmp-commits] [PATCH] D42472: [OMPT] Also test ompt_get_task_info() in task_types.c testcase

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jan 25 01:50:30 PST 2018


Hahnfeld requested changes to this revision.
Hahnfeld added a comment.
This revision now requires changes to proceed.

You need to update title and summary to reflect the latest changes and give some reasons.



================
Comment at: runtime/test/ompt/callback.h:74
+  if(frame)
+    printf("%" PRIu64 ": task level %d: parallel_id=%" PRIu64 ", task_id=%" PRIu64 ", exit_frame=%p, reenter_frame=%p, task_type=%s=%d, thread_num=%d\n", ompt_get_thread_data()->value, level, exists_task ? task_parallel_data->value : 0, exists_task ? task_data->value : 0, frame->exit_frame, frame->enter_frame, buffer, task_type, thread_num);
 }
----------------
I know we have been doing a poor job in the past, but this line is almost unreadable. Maybe we should start formatting all changes to tests with `clang-format` as well...


https://reviews.llvm.org/D42472





More information about the Openmp-commits mailing list