[Openmp-commits] [PATCH] D41817: [OMPT] Enable OMPT on 32-bit ARM machines

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D41817#972610, @pawosm01 wrote:

> Ok, relevant line changed. I didn't notice that although kmp_platform.h (where `KMP_ARCH_ARM` is defined) is included from callback.h, kmp_os.h where `KMP_COMPILER_GCC` is defined is not included.
>  Also note that both clang++ and g++ define `__GNUC__` hence full check for GNU C++ compiler looks as follows:
>
>   #if defined(__GNUC__) && !defined(__clang__)
>   #warning this is a GNU compiler
>   #else
>   #warning this is NOT a GNU compiler
>   #endif
>


I meant to say that you shouldn't check for GCC at all: You said the library doesn't work either if built with Clang, so there is no point in restricting `NULL` to GCC.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D41817