[Openmp-commits] [PATCH] D31600: KMP_HW_SUBSET extended with NUMA support when HWLOC enabled

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D31600#970035, @AndreyChurbanov wrote:

> I'd vote for closing this request (maybe approving it first). The problem with this patch you raised was fixed by the commit https://reviews.llvm.org/rL301349 (https://reviews.llvm.org/D32496).


If trunk works, there is nothing to do. The fix has been committed relatively close after the initial patch, so all release branches work.

> Maybe others have something to comment here, this is the second time we have problem with what to do with tiny fix of the problem in big already committed patch applied as a separate patch, as opposed to revert commit + merge the fix + reapply fixed patch.

Committing fixes for previous patches shouldn't require to revert the complete change first. This is normally done in LLVM/Clang repositories when the problem impacts many people and / or some time is needed to uncover and fix the problem.


Repository:
  rL LLVM

https://reviews.llvm.org/D31600