[Openmp-commits] [PATCH] D31600: KMP_HW_SUBSET extended with NUMA support when HWLOC enabled

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added a comment.
Herald added a subscriber: llvm-commits.

In https://reviews.llvm.org/D31600#969704, @pawosm01 wrote:

> what's the next step here?


I'd vote for closing this request (maybe approving it first). The problem with this patch you raised was fixed by the commit https://reviews.llvm.org/rL301349 (https://reviews.llvm.org/D32496).

An alternative would be to revert both https://reviews.llvm.org/rL300220 and https://reviews.llvm.org/rL301349, merge them into single patch, and update the https://reviews.llvm.org/D31600 with this patch.

Anyway, it does not look convenient to resolve the problem in already committed big patch by reverting it, fixing, etc., comparing to just apply the new small patch.

So between the two ways:

(1) reopen the review request that has problem, revert the corresponding commit, update the patch with fixed version, review, commit, close the old request;
(2) open bugzilla request, open new request with the fix, review, commit, close the new request.

I'd prefer to go the second way, unless there is policy that requires to go the fist one (I haven't found the policy anywhere so far).

Maybe others have something to comment here, this is the second time we have problem with what to do with tiny fix of the problem in big already committed patch applied as a separate patch, as opposed to revert commit + merge the fix + reapply fixed patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D31600