[Openmp-commits] [PATCH] D55588: [OpenMP] Fix nvidia-cuda-toolkit detection on Debian/Ubuntu

[George Rokos via Phabricator via Openmp-commits]

grokos added a comment.

Since a similar solution was adopted for clang, I think we should let this one land. After all, it's a matter of consistency between the two projects.



================
Comment at: openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake:116
+if (CUDA_TOOLKIT_ROOT_DIR)
+  set(cuda_toolkit_root_dir_old TRUE)
+endif()
----------------
There's a convention that cmake variables are capitalized. Also, cmake variables local to libomptarget should start with the prefix `LIBOMPTARGET_`. So this variable's name should be changed to `LIBOMPTARGET_CUDA_TOOLKIT_ROOT_DIR_PRESET` ("preset" makes more sense than "old").


================
Comment at: openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake:172
+
+set(cuda_libdevice_subdir nvvm/libdevice)
+
----------------
`LIBOMPTARGET_CUDA_LIBDEVICE_SUBDIR`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55588/new/

https://reviews.llvm.org/D55588