[Openmp-commits] [PATCH] D55788: Fix performance regression in SPEC kdtree test

[Andrey Churbanov via Phabricator via Openmp-commits]

AndreyChurbanov added inline comments.


================
Comment at: runtime/src/kmp_wait_release.h:254-261
-        pId = &(team->ompt_team_info.parallel_data);
         tId = &(team->ompt_task_info.task_data);
       } else {
-        pId = OMPT_CUR_TEAM_DATA(this_thr);
         tId = OMPT_CUR_TASK_DATA(this_thr);
       }
     } else {
----------------
Hahnfeld wrote:
> Are you sure that you want to remove this lookup? This means always passing `NULL` AFAICS
Once the value of pId is never used it should be OK to have it NULL for now.  Increased code size impacts performance of some tests, so we try to eliminate unused code when possible.


Repository:
  rOMP OpenMP

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55788/new/

https://reviews.llvm.org/D55788